Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require inspector module on production env #5228

Merged
merged 1 commit into from Jun 25, 2023

Conversation

dingiyan
Copy link
Contributor

@dingiyan dingiyan commented Jun 25, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

because of production env shouldn't use inspector module and such as vercel/pkg custom node runtime remove it. so we hope egg disable inspector on production env.

closes #5226

because of   production env shouldn't use inspector module and such as vercel/pkg custom node runtime remove it.
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 changed the title fix:disable inspector module on production env. fix: disable inspector module on production env Jun 25, 2023
@fengmk2 fengmk2 changed the title fix: disable inspector module on production env fix: don't require inspector module on production env Jun 25, 2023
@fengmk2 fengmk2 self-assigned this Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a0ba9c3) 99.86% compared to head (7979df5) 99.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5228      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          36       36              
  Lines        3605     3604       -1     
  Branches      515      516       +1     
==========================================
- Hits         3600     3599       -1     
  Misses          5        5              
Impacted Files Coverage Δ
lib/egg.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit 398fe15 into eggjs:master Jun 25, 2023
18 checks passed
fengmk2 pushed a commit that referenced this pull request Jun 25, 2023
[skip ci]

## [3.17.2](v3.17.1...v3.17.2) (2023-06-25)

### Bug Fixes

* don't require inspector module on production env ([#5228](#5228)) ([398fe15](398fe15))
@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

@dingiyan 感谢贡献!

@dingiyan
Copy link
Contributor Author

项目中遇到的问题,感谢采纳 @fengmk2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

是否可以在生产环境下取消使用inspector
2 participants