Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing args definition on runSchedule #5232

Merged
merged 1 commit into from Jun 29, 2023

Conversation

DevXiaolan
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

index.d.ts Show resolved Hide resolved
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 changed the title definition of runSchedule fix: add missing args definition of runSchedule Jun 29, 2023
@fengmk2 fengmk2 changed the title fix: add missing args definition of runSchedule fix: add missing args definition on runSchedule Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ba3d62) 99.86% compared to head (5469e3d) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5232   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          36       36           
  Lines        3604     3604           
  Branches      516      516           
=======================================
  Hits         3599     3599           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit f90763b into eggjs:master Jun 29, 2023
18 checks passed
fengmk2 pushed a commit that referenced this pull request Jun 29, 2023
[skip ci]

## [3.17.3](v3.17.2...v3.17.3) (2023-06-29)

### Bug Fixes

* add missing args definition on runSchedule ([#5232](#5232)) ([f90763b](f90763b))
@fengmk2
Copy link
Member

fengmk2 commented Jun 29, 2023

@DevXiaolan Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants