Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not overwrite extension file #218

Merged
merged 2 commits into from Apr 28, 2024
Merged

fix: not overwrite extension file #218

merged 2 commits into from Apr 28, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Apr 28, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Summary by CodeRabbit

  • New Features

    • Enhanced code generation logic to dynamically determine paths, improving flexibility in project structure.
    • Introduced a new custom SQL query for FooExtension to perform specific database operations.
    • Added a new TypeScript class Foo representing a database table with comprehensive data type support and indexing.
  • Bug Fixes

    • Updated code generation settings to prevent overwriting existing codes, ensuring data integrity.
  • Tests

    • Added test cases to validate the new code generation logic and directory-specific operations.

Copy link

coderabbitai bot commented Apr 28, 2024

Walkthrough

This update brings enhancements to the dal-runtime module, focusing on smarter path determination for data access layers and preventing overwrites during code generation. It includes ignoring a specific directory pattern in version control, new test cases, and configurations for robust code generation capabilities.

Changes

File Path Change Summary
.gitignore Added exclusion for dal-runtime/test/fixtures/modules/*/src/dal/ with an exception for FooExtension.ts
core/dal-runtime/src/CodeGenerator.ts Dynamically sets dalDir path and changed overwrite in codes to false
core/dal-runtime/test/.../CodeGenerator.test.ts Added test for code generation in src directory and content verification
core/dal-runtime/test/fixtures/.../FooExtension.ts Introduces a new SQL query customFind in FooExtension
core/dal-runtime/test/fixtures/.../package.json Added configuration for "dal" module in package.json
core/dal-runtime/test/fixtures/.../src/Foo.ts Defines Foo class representing egg_foo table with various data type decorations
.github/workflows/nodejs.yml Updated MySQL start command to accommodate different paths for arm64/x86 Homebrew installations

🐇✨📜
In the burrows of code, where the data streams flow,
A rabbit hopped in, with updates in tow.
Paths now smarter, overwrites cease,
In the land of DAL, there's newfound peace.
Celebrate we shall, with a carrot feast, cheers! 🥕🎉
🐇✨📜


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4633ac5 and 010dea4.
Files selected for processing (1)
  • .github/workflows/nodejs.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/nodejs.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@gxkl gxkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killagu killagu merged commit f915f08 into master Apr 28, 2024
9 checks passed
@killagu killagu deleted the fix/dal_extensions branch April 28, 2024 09:26
@killagu
Copy link
Contributor Author

killagu commented Apr 28, 2024

  • @eggjs/ajv-decorator@3.39.1
  • @eggjs/aop-decorator@3.39.1
  • @eggjs/controller-decorator@3.39.1
  • @eggjs/core-decorator@3.39.1
  • @eggjs/dal-decorator@3.39.1
  • @eggjs/dal-runtime@3.39.1
  • @eggjs/egg-module-common@3.39.1
  • @eggjs/eventbus-decorator@3.39.1
  • @eggjs/standalone-decorator@3.39.1
  • @eggjs/tegg@3.39.1
  • @eggjs/tegg-ajv-plugin@3.39.1
  • @eggjs/tegg-aop-plugin@3.39.1
  • @eggjs/tegg-aop-runtime@3.39.1
  • @eggjs/tegg-background-task@3.39.1
  • @eggjs/tegg-common-util@3.39.1
  • @eggjs/tegg-config@3.39.1
  • @eggjs/tegg-controller-plugin@3.39.1
  • @eggjs/tegg-dal-plugin@3.39.1
  • @eggjs/tegg-dynamic-inject@3.39.1
  • @eggjs/tegg-dynamic-inject-runtime@3.39.1
  • @eggjs/tegg-eventbus-plugin@3.39.1
  • @eggjs/tegg-eventbus-runtime@3.39.1
  • @eggjs/tegg-lifecycle@3.39.1
  • @eggjs/tegg-loader@3.39.1
  • @eggjs/tegg-metadata@3.39.1
  • @eggjs/tegg-orm-decorator@3.39.1
  • @eggjs/tegg-orm-plugin@3.39.1
  • @eggjs/tegg-plugin@3.39.1
  • @eggjs/tegg-runtime@3.39.1
  • @eggjs/tegg-schedule-decorator@3.39.1
  • @eggjs/tegg-schedule-plugin@3.39.1
  • @eggjs/tegg-standalone@3.39.1
  • @eggjs/tegg-transaction-decorator@3.39.1
  • @eggjs/tegg-types@3.39.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants