Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on tidying all tabs of current window #108

Open
rxw1 opened this issue Oct 13, 2018 · 1 comment
Open

Crashes on tidying all tabs of current window #108

rxw1 opened this issue Oct 13, 2018 · 1 comment

Comments

@rxw1
Copy link

rxw1 commented Oct 13, 2018

Crashes when clicking "Tidy n tabs". The tidytab dashboard is then the last open tab and doesn't load/stays white. ... Chrome's "Collect Errors" feature pointed to the store at line 189 where we hydrate "whenever we come back to the dashboard":

tidytab/app/store/index.js

Lines 188 to 191 in e698609

chrome.tabs && chrome.tabs.onHighlighted.addListener(changedWindow => {
if (changedWindow.tabIds[0] !== currentTab.id) return
store.dispatch('HYDRATE_STATE')
})

@briangonzalez
Copy link
Contributor

@rwilhelm Thanks for the issue! When did this start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants