Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright attribution #1

Closed
eggyal opened this issue Jan 2, 2023 · 2 comments
Closed

Copyright attribution #1

eggyal opened this issue Jan 2, 2023 · 2 comments
Labels

Comments

@eggyal
Copy link
Owner

eggyal commented Jan 2, 2023

Copyright in the original liballoc code rests with each individual contributor, albeit dual-licensed by them under MIT and Apache-2.0 at user discretion. I'm happy for copse to adopt the same approach for its contributions.

However, correctly attributing copyright therefore requires incorporating liballoc's git history into this repo (albeit that should also ease tracking/merging of upstream changes in future too).

Unfortunately that's not entirely straightforward, as git doesn't enable one to link only to another repo's subfolder: we'll probably need to maintain our own fork of the entire rust-lang/rust repo, include that fork as a submodule, and then (I guess) use a #[path] attribute to set our btree module to use the relevant file from that submodule?

I'm not 100% clear about this however: will investigate, or else any suggestions/PRs welcome!

@eggyal
Copy link
Owner Author

eggyal commented Jan 2, 2023

After a little research, I'm leaning toward a strategy based upon (periodic/scheduled) automated git subtree split of liballoc's btree folder into a temporary repo, followed by a subtree pull that merges any changes into this repo's copy of that folder.

As part of #2, I'll be looking into whether there are any GitHub actions out there that will do this by opening a PR (which would be ideal).

@eggyal eggyal added the meta label Jan 2, 2023
@eggyal eggyal closed this as completed Jan 9, 2023
@eggyal
Copy link
Owner Author

eggyal commented Jan 9, 2023

Fixed in b9c0735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant