Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log verbosity #7

Closed
rahulaga opened this issue Sep 25, 2014 · 9 comments · Fixed by #8
Closed

Log verbosity #7

rahulaga opened this issue Sep 25, 2014 · 9 comments · Fixed by #8

Comments

@rahulaga
Copy link
Contributor

Enhancement request. To have cleaner logs it would be good if after one succesful collection we stop logging success. For example:
[2014-09-25 18:20:47] FastJMX plugin: [failed:0, canceled:0, successful:11] in 8ms with: 2 threads

@bvarner
Copy link
Contributor

bvarner commented Sep 25, 2014

Thanks! I'll move this to debug level in the future -- I don't have a collectd version with debug enabled at the moment, so I'm looging at info. :-(

@bvarner
Copy link
Contributor

bvarner commented Oct 8, 2014

New version in master that should greatly reduce logging, as well as make things a bit more stable in terms of resource usage. I know my use cases are bit more demanding than most right now.

I'll start looking at the redeployed beans issue in JBoss soon...

@rahulaga
Copy link
Contributor Author

rahulaga commented Oct 8, 2014

Thanks Bryan, I'll try to get an update. I have FastJMX running nicely on my dev env for couple weeks now - I mentioned the workaround I have about Jboss in the other ticket.

@rahulaga
Copy link
Contributor Author

So I updated the fast jmx jar and it does not work anymore. Are there any config changes that I must make as well? I've reverted back to older version.
Just this error which is of no help:
[2014-10-17 16:54:00] FastJMX Plugin: Unexpected Throwable: java.lang.NullPointerException

@bvarner
Copy link
Contributor

bvarner commented Oct 17, 2014

Yikes! I cannot think of any required changes... What happens if you include log level configurations?

On Oct 17, 2014, at 1:44 PM, Rahul notifications@github.com wrote:

So I updated the fast jmx jar and it does not work anymore. Are there any config changes that I must make as well? I've reverted back to older version.
Just this error which is of no help:
[2014-10-17 16:54:00] FastJMX Plugin: Unexpected Throwable: java.lang.NullPointerException


Reply to this email directly or view it on GitHub.

@rahulaga
Copy link
Contributor Author

I didn't update anything... I just replaced the jar with the new one. The problem could be that I modified your source - I left a code comment so take a look. The master does not compile with Java 1.5 as defined in the pom.

@bvarner
Copy link
Contributor

bvarner commented Oct 17, 2014

I saw that note earlier and have not had a chance to look into it yet.

On Oct 17, 2014, at 4:35 PM, Rahul notifications@github.com wrote:

I didn't update anything... I just replaced the jar with the new one. The problem could be that I modified your source - I left a code comment so take a look. The master does not compile with Java 1.5 as defined in the pom.


Reply to this email directly or view it on GitHub.

@rbartl
Copy link

rbartl commented Dec 29, 2014

got that Unexpected Throwable: java.lang.NullPointerException error in my fresh setup.
After some added debugging i found it was a missing java_memory line in the types.db file.

types.db
java_memory value:GAUGE:0:U

a null pointer exception in the config method was preventing the executor field to be set.
A try catch block around the whole config block to see these config errors would be a good idea.

@bvarner
Copy link
Contributor

bvarner commented Dec 29, 2014

I've opened issue #14 to track your suggested change. Thanks, rbartl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants