New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for overriding delimiter. #96

Merged

bvarner merged 1 commit into development from feature/other_branch_delimiter

Aug 29, 2018

Contributor

bvarner commented Aug 29, 2018

Many other opinionated systems don't like having + in the version string.

Specifically, you can't use that within say, a docker tag.


          Addresses #95

bdea578

coveralls commented Aug 29, 2018

Pull Request Test Coverage Report for Build 370

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.459%

Totals
Change from base Build 368:	0.0%
Covered Lines:	584
Relevant Lines:	795

💛 - Coveralls

bvarner merged commit 9d5c2aa into development

bvarner deleted the feature/other_branch_delimiter branch

August 29, 2018 20:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment