Fix bug when passing multiple arguments to log #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zant
changed the title
Prozi
reviewed
Aug 29, 2019
src/utils/proxy-console.js
Outdated
| @@ -200,6 +200,12 @@ | |||
| } | |||
|
|
|||
| const replacements = args[0].match(/(%[sc])([^%]*)/gm) | |||
|
|
|||
| // If no replacement is found, we return a unstyled text | |||
| if (!replacements || replacements === null) { | |||
There was a problem hiding this comment.
if (!replacements) {
is the same but shorter
There was a problem hiding this comment.
actually pleace change to
if (!replacements || !replacements.length) {
because we do replacements.shift() below that
anyway Thanks for contribution! 馃憤
Prozi
suggested changes
Aug 29, 2019
zant
commented
Aug 30, 2019
| @@ -174,7 +174,7 @@ | |||
| */ | |||
| const styleText = function (textArray, styles = []) { | |||
| return textArray.map((text, index) => { | |||
| return index ? `<span style="${styles.shift()}">${text}</span>` : text | |||
| return index ? `<span style="${styles.shift()}">${stringify(text)}</span>` : text | |||
There was a problem hiding this comment.
@Prozi the item in WIP is referring to this:
because styleText is not expecting arrays at all, but if we stringify whatever arguments that are passed in, the function can handle and return those as strings properly
zant
changed the title
|
Can you do a follow up please? @Prozi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey!
really good playground, super nice, i already switch from jsbin to codepan 馃
i made this PR because i notice that when calling
console.logwith multiple arguments, the following error appears in the integrated console:the error was due to the support of styling logs, i just check if any styling is intended, and if is not, it should return an unstyled text, i also added a blank when joining arguments to have them separated, but i'm not aware of the use case of the previous way
TODO:
please review @egoist @Prozi :)