Limit threads when transpiling with node-sass #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
+ Coverage 95.02% 95.1% +0.08%
=========================================
Files 8 8
Lines 241 245 +4
Branches 83 84 +1
=========================================
+ Hits 229 233 +4
Misses 12 12
Continue to review full report at Codecov.
|
|
It looks like the patch codecov is failing but was already lower than the threshold even before this PR. Is there some test you think should be added @egoist? |
bung87
pushed a commit
to bung87/rollup-plugin-postcss
that referenced
this pull request
Dec 3, 2019
This PR introduces a worker queue which limits the number of concurrent threads similar to how webpack [sass-loader](https://github.com/webpack-contrib/sass-loader/blob/2529c0716b1bca321c22d16636b1385682b1c730/lib/loader.js#L14) does. The changes are a workaround for the issues in node-sass discussed in egoist#104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a worker queue which limits the number of concurrent threads similar to how webpack sass-loader does. The changes are a workaround for the issues in node-sass discussed in #104.