Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract relative path #262

Merged
merged 2 commits into from
Apr 19, 2020

Conversation

SASUKE40
Copy link
Collaborator

Fixes #250

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   92.42%   92.47%   +0.04%     
==========================================
  Files          10       10              
  Lines         317      319       +2     
  Branches      113      112       -1     
==========================================
+ Hits          293      295       +2     
  Misses         23       23              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 98.97% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df71f37...14b12b6. Read the comment docs.

@SASUKE40 SASUKE40 merged commit 0e71f75 into egoist:master Apr 19, 2020
@SASUKE40 SASUKE40 changed the title Fix/extract relative path fix: extract relative path Apr 19, 2020
@egoist
Copy link
Owner

egoist commented Apr 19, 2020

🎉 This PR is included in version 2.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

SASUKE40 added a commit to SASUKE40/rollup-plugin-postcss that referenced this pull request Apr 19, 2020
* test: add extract relative path

* fix: extract relative path
@calebeby
Copy link

This should have been released as a major version because this is a breaking change for this use case:

postcss({extract: 'dist/style.css'})

In 2.8.1 this correctly placed the file in the relative location of dist/style.css. In 2.8.2 this does not place the file there

@SASUKE40
Copy link
Collaborator Author

related #266

@SASUKE40
Copy link
Collaborator Author

This should have been released as a major version because this is a breaking change for this use case:

postcss({extract: 'dist/style.css'})

In 2.8.1 this correctly placed the file in the relative location of dist/style.css. In 2.8.2 this does not place the file there

I have released two version:

  • v2.9.0@latest for rollup v1 and v2(it prints some warning messages when using custom extract).
  • v3.0.0@next only for rollup v2(not allow generate files outside bundle directory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants