Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle importing Sass partials in node_modules #90

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

ryanoglesby08
Copy link
Contributor

This fixes #86 by handling importing Sass partials from node_modules, so that something like this will work properly: @import ~foo/bar/partial where "partial" has the filename "_partial.scss".

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #90 into master will decrease coverage by 0.19%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #90     +/-   ##
=========================================
- Coverage   95.06%   94.87%   -0.2%     
=========================================
  Files           8        8             
  Lines         223      234     +11     
  Branches       81       81             
=========================================
+ Hits          212      222     +10     
- Misses         11       12      +1
Impacted Files Coverage Δ
src/sass-loader.js 92% <90%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283aac4...2ce93ba. Read the comment docs.

@ryanoglesby08
Copy link
Contributor Author

Hi @egoist, is there anything else I can do here to move this along? Would like to upgrade to v1, but the bug that this fixes is blocking that for my project. Thanks for the great package by the way. Let me know how else I can help here.

@egoist egoist merged commit 347d570 into egoist:master Apr 17, 2018
bung87 pushed a commit to bung87/rollup-plugin-postcss that referenced this pull request Dec 3, 2019
* fix: handle importing Sass partials in node_modules

* tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing SCSS partial from node_modules ends with not found module.
2 participants