Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle config file killed docs suggestion of using "export const tsup" #351

Closed
PabloSzx opened this issue Jul 6, 2021 · 4 comments
Closed
Labels

Comments

@PabloSzx
Copy link
Contributor

PabloSzx commented Jul 6, 2021

as seen in the commit 7d03efe#diff-51cd61f2399d311debdd2c813260b4a799b0cd6155b8eaa0f1498aebdc5ca281

that kills the syntax export const tsup https://tsup.egoist.sh/#typescript since you removed if (config.data && config.data.tsup) config.data = config.data.tsup @egoist

checking the "tsup" property shouldn't be "package.json" exclusive

@PabloSzx PabloSzx changed the title bundleConfigFile killed docs suggestion bundle config file killed docs suggestion of using "export const tsup" Jul 6, 2021
@egoist
Copy link
Owner

egoist commented Jul 6, 2021

Ahh I didn't notice that

@egoist egoist closed this as completed in fc8d689 Jul 6, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

🎉 This issue has been resolved in version 4.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist
Copy link
Owner

egoist commented Jul 6, 2021

Actually here's an alternative way to get doc suggestion when using default export:

import { defineConfig } from "tsup"

export default defineConfig({
  entryPoints: ["foo.js"],
})

@PabloSzx
Copy link
Contributor Author

PabloSzx commented Jul 6, 2021

I agree that looks cleaner, and thanks for fixing the issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants