Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wanted] Support inject style #479

Closed
zhmushan opened this issue Dec 2, 2021 · 3 comments · Fixed by #483
Closed

[Wanted] Support inject style #479

zhmushan opened this issue Dec 2, 2021 · 3 comments · Fixed by #483
Labels
contribution welcome css enhancement New feature or request

Comments

@zhmushan
Copy link
Contributor

zhmushan commented Dec 2, 2021

No description provided.

@zhmushan zhmushan changed the title [Wanted] Inject style [Wanted] Support inject style Dec 2, 2021
@egoist
Copy link
Owner

egoist commented Dec 6, 2021

that's nice to have, but I'm not sure how to implement this

@egoist
Copy link
Owner

egoist commented Dec 6, 2021 •
edited

If you load css as a js module styleInject("..css code") then you can't take advantage of esbuild to minify the CSS cde.

@egoist
Copy link
Owner

egoist commented Dec 6, 2021

just realized we can use esbuild.transform to minify the CSS code on demand, so maybe that'll work.

@zhmushan zhmushan mentioned this issue Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome css enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Simple CSS injection support
2 participants
@egoist @zhmushan