Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: MinifyOptions re-exported from terser by tsup include invalid typings when processed by rollup-plugin-dts #834

Closed
favna opened this issue Feb 12, 2023 · 4 comments
Labels

Comments

@favna
Copy link

favna commented Feb 12, 2023

After updating tsup to to v6.6.0 our build is failing when running a general type checking with --noEmit because the typings of tsup re-export the typings of terser which in turn are incorrectly parsed by rollup-plugin-dts. The error log can be found here: https://github.com/sapphiredev/shapeshift/actions/runs/4156157046/jobs/7189739909 and/or https://github.com/skyra-project/char/actions/runs/4156157083/jobs/7189740023

I know the root cause here is either terser or the dts plugin, but I also don't think either of those libraries can really realistically fix the issue so I'm hoping you can fix it on the tsup side.

For now I can apply a yarn patch to circumvent the issue, but that is less than ideal.

@egoist egoist closed this as completed in a85439d Feb 12, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 6.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@favna
Copy link
Author

favna commented Feb 12, 2023

Hi, thanks for the quick resolution, but that change doesn't appear to have fixed the issue:

image

@egoist
Copy link
Owner

egoist commented Feb 12, 2023

try 6.6.2

@favna
Copy link
Author

favna commented Feb 12, 2023

Can confirm the issue has been resolved with v6.6.2, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants