Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onSuccess process is not killed when @highlight-run/node is imported #936

Closed
egoist opened this issue Jun 25, 2023 · 2 comments
Closed

onSuccess process is not killed when @highlight-run/node is imported #936

egoist opened this issue Jun 25, 2023 · 2 comments
Labels
bug Something isn't working released

Comments

@egoist
Copy link
Owner

egoist commented Jun 25, 2023 •
edited

In watch mode, the onSuccess process couldn't be successfully killed when you use @highlight-run/node in your code.
@egoist egoist added the bug Something isn't working label Jun 25, 2023
@egoist
Copy link
Owner Author

egoist commented Jun 25, 2023 •
edited

Works when using SIGKILL here:

https://github.com/egoist/tsup/blob/c151d5327c71fc28e9f72f0f96f16f41d7f6786e/src/index.ts#L39C1

@egoist egoist closed this as completed in 612cabf Jun 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This issue has been resolved in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egoist