Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.2.18 tagged from master branch #243

Closed
remicollet opened this issue Jun 17, 2020 · 4 comments
Closed

Version 1.2.18 tagged from master branch #243

remicollet opened this issue Jun 17, 2020 · 4 comments
Labels
bug

Comments

@remicollet
Copy link
Contributor

Looks like a bad tag...

Shouldn't this be a 2.1.18, not a 1.2.18 ?
@remicollet
Copy link
Contributor Author

@siwinski FYI

@egulias egulias added the bug label Jun 17, 2020
@egulias
Copy link
Owner

egulias commented Jun 17, 2020

Yes, you were right. Removed and retagged.
Thanks!

@egulias egulias closed this as completed Jun 17, 2020
@mlocati
Copy link
Contributor

mlocati commented Jun 17, 2020

The tag is still there, breaking all sites that use version 1... See https://github.com/egulias/EmailValidator/releases/tag/1.2.18 and https://packagist.org/packages/egulias/email-validator#1.2.18

@mlocati mlocati mentioned this issue Jun 17, 2020
Merged
@mlocati
Copy link
Contributor

mlocati commented Jun 17, 2020

PS: it should be enough to run git push origin :refs/tags/1.2.18 to delete the tag on GitHub, which should trigger an update on Packagist.

@mlocati mlocati mentioned this issue Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@remicollet @egulias @mlocati