Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtick in domain is incorrectly considered valid #272

Closed
Jamesking56 opened this issue Nov 11, 2020 · 1 comment
Closed

Backtick in domain is incorrectly considered valid #272

Jamesking56 opened this issue Nov 11, 2020 · 1 comment
Labels

Comments

@Jamesking56
Copy link

$validator = new EmailValidator();
$result = $validator->isValid("someone@email`s.com", new RFCValidation());

$result returns true when it should return false, Backticks aren't allowed in the domain portion according to the RFC

@egulias egulias added the bug label Nov 14, 2020
@egulias
Copy link
Owner

egulias commented Nov 14, 2020

Thanks for reporting @Jamesking56 .
Arguably, it is valid in the broader definition of the RFC 5322, see https://tools.ietf.org/html/rfc5322#section-3.4.1 . It is true that regarding RFC1035 backtick is not allowed.
I'll address it, nevertheless, this is a behaviour change since this V2 of the validator follows the broader definition. This will change in V3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants