Message-id validator #290
Merged
Message-id validator #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate your thoughts @driesvints @derrabus , this should fix Swiftmailer & Symfony mailer needs. |
derrabus
approved these changes
Feb 28, 2021
src/MessageIDParser.php
Outdated
Comment on lines
30
to
33
| public function __construct(EmailLexer $lexer) | ||
| { | ||
| $this->lexer = $lexer; | ||
| } |
There was a problem hiding this comment.
The constructor could be moved to the new Parser class as well.
|
Awesome. I'm not sure when I'll have time to try this out but hope to soon. Thanks! |
|
Hey @egulias. I can confirm this fixes the failing test for SwiftMailer. Thanks! I'll keep an eye out until a new release with this has been tagged and then I'll send in a patch to SwiftMailer. |
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Co-authored-by: Alexander M. Turek <me@derrabus.de>
…tor into message-id-validator
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message-id header validation according to RFC2822 section 3.6.4. This header field has some differences to an addr-spec, like not allowing comments and explicity allowing for many other charcters in the "domain part".
For message-id, parts are
id-left@id-right.Added a new validator, refactor of internals to allow for extension.
Fixes #282 & symfony/symfony#39685