Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #1 fix (GetSyscallFnNameWithSymFile memory leak) #2

Merged
merged 1 commit into from
Mar 20, 2022
Merged

issue #1 fix (GetSyscallFnNameWithSymFile memory leak) #2

merged 1 commit into from
Mar 20, 2022

Conversation

chriskaliX
Copy link
Contributor

@chriskaliX chriskaliX commented Mar 20, 2022 •
edited by cfc4n

issue #1 fix.

@chriskaliX
Copy link
Contributor Author

chriskaliX commented Mar 20, 2022 •
edited

I extract the function GetSyscallFnNameWithSymFile, and run a loop of 10 as an example. It looks like a memory leak due to substring.
And here is my reference: https://go101.org/article/memory-leaking.html

After fixing, it looks fine now

@cfc4n cfc4n changed the title #issue1 fix issue #1 fix (GetSyscallFnNameWithSymFile memory leak) Mar 20, 2022
@cfc4n cfc4n merged commit b344aab into gojue:master Mar 20, 2022
@cfc4n
Copy link
Member

cfc4n commented Mar 20, 2022

LGTM,thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chriskaliX @cfc4n