Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lts alias value is wrong #8

Closed
2 of 3 tasks
hongaar opened this issue Dec 13, 2022 · 2 comments
Closed
2 of 3 tasks

lts alias value is wrong #8

hongaar opened this issue Dec 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@hongaar
Copy link

hongaar commented Dec 13, 2022

Guidelines

  • Please search other issues to make sure this bug has not already been reported.
  • If this is related to a typo or the documentation being unclear, please click on the relevant page's Edit button (pencil icon) and suggest a correction instead.

Describe the bug

Version resolver yields different results than nvm. When trying to resolve lts/-1 I got back 18.12.1 but I expected 16.18.1.

Steps to reproduce

node-version-alias

import nodeVersionAlias from "node-version-alias";

console.log("lts/*", await nodeVersionAlias("lts/*"));
console.log("lts/-1", await nodeVersionAlias("lts/-1"));
console.log("lts/-2", await nodeVersionAlias("lts/-2"));

prints

lts/* 18.12.1
lts/-1 18.12.1
lts/-2 16.18.1

vs

nvm

$ nvm version-remote lts/*
v18.12.1
$ nvm version-remote lts/-1
v16.18.1
$ nvm version-remote lts/-2
v14.21.1

Configuration

n/a

Environment

  System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
    Memory: 5.88 GB / 7.69 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.18.1 - ~/.nvm/versions/node/v16.18.1/bin/node
    Yarn: 3.3.0 - /usr/bin/yarn
    npm: 8.19.3 - ~/Code/hongaar/update-node-versions/node_modules/.bin/npm
  npmPackages:
    node-version-alias: 3.4.0 => 3.4.0

Pull request (optional)

  • I can submit a pull request.
@hongaar hongaar added the bug Something isn't working label Dec 13, 2022
@ehmicky ehmicky changed the title Please replace with a clear and descriptive title lts alias value is wrong Dec 13, 2022
@ehmicky
Copy link
Owner

ehmicky commented Dec 13, 2022

Hi @hongaar,

Thanks for finding this! This has now been fixed in the latest release 3.4.1.

@all-contributors Please add @hongaar for bug report.

@allcontributors
Copy link
Contributor

@ehmicky

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @hongaar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants