Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Define charset for Luhn-Mod-N algorithm #45

Closed
gabywh opened this issue Apr 29, 2021 · 8 comments
Closed

Define charset for Luhn-Mod-N algorithm #45

gabywh opened this issue Apr 29, 2021 · 8 comments
Assignees
Milestone

Comments

@gabywh
Copy link
Collaborator

gabywh commented Apr 29, 2021

#38 (comment)

closes #38

@gabywh gabywh added this to the Version 1.0 milestone Apr 29, 2021
@gabywh gabywh self-assigned this Apr 29, 2021
@gabywh
Copy link
Collaborator Author

gabywh commented Apr 29, 2021

Option 3 to be used.
#44 (comment)

@gabywh
Copy link
Collaborator Author

gabywh commented Apr 29, 2021

@jschlyter regex pattern for schema?

@martin-lindstrom
Copy link
Contributor

My vote is also on option 3, but we need to decide on the charset.

  • The prefix I see in examples "urn:uvci:". I guess we add that after the Luhn-calculation?
  • Luhn charset? ABCDE...XYZ0123456789/:

@dirkx
Copy link
Member

dirkx commented Apr 29, 2021 via email

@jschlyter
Copy link
Contributor

The specs refers to RFC 3986, but the UVCI are not URIs?

@dirkx
Copy link
Member

dirkx commented Apr 29, 2021 via email

@gabywh
Copy link
Collaborator Author

gabywh commented Apr 29, 2021

Are we talking Luhn-Mod-N or Luhn-10 here?
Annex 2 in the eHN Vacc Interop states:

This checksum should be the ISO-7812-1 (LUHN-10) summary of the entire UVCI in digital/wire transport format.

(@martin-lindstrom so I guess that answers your question about scope of the checksum)

@gabywh
Copy link
Collaborator Author

gabywh commented Apr 29, 2021

Are we talking Luhn-Mod-N or Luhn-10 here?
Annex 2 in the eHN Vacc Interop states:

This checksum should be the ISO-7812-1 (LUHN-10) summary of the entire UVCI in digital/wire transport format.

Luhn-Mod-N would make sense here, Luhn-10 not, and the footnote (7) also discusses Luhn-Mod-N, so is the Luhn-10 reference simply a small error?

Luhn-10 is the only ISO spec I know of in this context and AFAIK Luhn-Mod-N was never ISO (maybe someone else knows better?), so I can understand the Luhn-10 reference from that perspective, but that makes the text confusing since it clearly states Luhn-10 should be used.

Suggest wording to be sth like:

"Luhn-Mod-N algorithm shall be used" and in footnote 7 explain that Luhn-Mod-N is a variant on the basic Luhn-Mod-10 as per ISO 7812-1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants