Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version alert #16

Closed
ehne opened this issue Oct 25, 2021 · 1 comment
Closed

Add new version alert #16

ehne opened this issue Oct 25, 2021 · 1 comment

Comments

@ehne
Copy link
Owner

ehne commented Oct 25, 2021

Probably should let the user know if there is a new feature or patch version. So that they can download the new version and get whatever fix.

Proposed solution

Check on the localhost ui, and put a banner up if there is a new version. Probably reuse some of the code from the gh-pages branch, and how the docs have the version switcher.

In terms of sending the installed version of PyNode Next to the client, just dispatch an event when the user connects to the socket. (through self.canvas.onmessage or something like that)

version_dispatch_dict = {'isPyNodeNext': True, 'type': 'version', 'message': 'v1.9.1'}
self.canvas.onmessage('getPyNodeNextVersion', lambda: self.canvas.dispatch(version_dispatch_dict))
let socket = initSocket(function() { 
  canvas.message('getPyNodeNextVersion') 
}, dispatch);

And then just grab the message in the js dispatch function and handle it.

@ehne
Copy link
Owner Author

ehne commented Oct 26, 2021

Should be closed by 88c03d9 when it is merged.

@ehne ehne closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant