Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.keys(set) inconsistency #3

Open
matthewoates opened this issue Oct 28, 2015 · 0 comments
Open

Object.keys(set) inconsistency #3

matthewoates opened this issue Oct 28, 2015 · 0 comments

Comments

@matthewoates
Copy link

Great work, and it's unfortunate that Ember never delivered on their promise of a drop-in replacement of Set.

I did discover one inconsistency with this implementation.

Using your set:
Object.keys(new Set()) // ['_content']

Using the deprecated version from 1.x:
Object.keys(new Ember.Set()) // []

Also, Object.keys will pick up any elements added to an Ember.Set.

Not sure if this is fixable. If not, definitely worth noting in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant