Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector Apodizing Phase Plate is broken #63

Closed
spbos opened this issue Feb 24, 2020 · 2 comments · Fixed by #64
Closed

vector Apodizing Phase Plate is broken #63

spbos opened this issue Feb 24, 2020 · 2 comments · Fixed by #64
Labels
bug Something isn't working

Comments

@spbos
Copy link
Collaborator

spbos commented Feb 24, 2020

When generating a vAPP object, the code returns an error because the Class tries to supply a wavelength to the GeometricPhaseElement. Which is not required anymore.

The fix is:
GeometricPhaseElement.init(self, phase_pattern, leakage, retardance_offset, wavelength)
-->
GeometricPhaseElement.init(self, phase_pattern, leakage, retardance_offset)
@syhaffert syhaffert mentioned this issue Feb 24, 2020
Merged
@syhaffert
Copy link
Collaborator

I have issued a pull request to fix this bug.

@spbos
Copy link
Collaborator Author

spbos commented Feb 24, 2020

Thanks!

@ehpor ehpor added the bug Something isn't working label Feb 24, 2020
@ehpor ehpor linked a pull request Feb 24, 2020 that will close this issue
remove wavelength from vapp #64
Merged
@ehpor ehpor closed this as completed in #64 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove wavelength from vapp ehpor/hcipy
3 participants
@syhaffert @ehpor @spbos