Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAT composition participation - wrong uniqueness lookup for id & name #710

Closed
dileep-ehr opened this issue Dec 15, 2021 · 0 comments · Fixed by #724
Closed

FLAT composition participation - wrong uniqueness lookup for id & name #710

dileep-ehr opened this issue Dec 15, 2021 · 0 comments · Fixed by #724
Labels
bug Something isn't working

Comments

@dileep-ehr
Copy link

Configuration information

<ehrbase_version>0.19.0-SNAPSHOT</ehrbase_version>
<openehr_sdk_version>1.7.0-SNAPSHOT</openehr_sdk_version>
<archie_version>1.0.4</archie_version>
<jvm_version>Ubuntu 11.0.11+9-Ubuntu-0ubuntu2.18.04</jvm_version>
<os_version>Linux amd64 5.4.0-91-generic</os_version>
<postgres_version>PostgreSQL 14.1 (Ubuntu 14.1-1.pgdg18.04+1) on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0, 64-bit</postgres_version>

Steps to reproduce

Giving the following fields for participation
```
"cbc_report/context/_participation:0|name": "Frederick Wolfstein",
"cbc_report/context/_participation:0|id": "9990",
"cbc_report/context/_participation:0|function": "performer",
"cbc_report/context/_participation:0|mode": "face-to-face communication",
"cbc_report/context/_participation:0|id_namespace": "EHR.NETWORK",
"cbc_report/context/_participation:0|id_scheme": "UUID",

If you reuse name & id values, the following is observed

Use same name and another id -  The given values are overwritten with values that match the name in the external reference table
Use same id  and another name - The given values are overwritten with values that match the id in the external reference table

So we can use any name and id only once any instance of EHRbase, which I feel will be a serious limitation.

## Actual result ##

Both name and id are considered unique in the external reference table

## Expected result (Acceptance Criteria) ##

Name and ID should not be unique as there is a chance that these could be repeated between different id_namespaces and or different id_schema within the same id_namespace. The uniqueness should be a combination of id, id_namespace & id_scheme, as you cannot have the same id for an id_scheme in any id_namespace. 

## Definition of Done ##

<!-- These checklist entries are used by our developers to deliver a solution with a base quality
we want to acheive. If you want to add other points specific to this issue, put them into the section

"Expected result (Acceptance Criteria)" -->

- [ ] The defect is checked by an unit or an integration test (Robot)
- [ ] Merge Request approved
- [ ] Unit tests passed
- [ ] Build without errors
- [ ] Release notes prepared
- [ ] No additional runtime warnings
@dileep-ehr dileep-ehr added the bug Something isn't working label Dec 15, 2021
@dileep-ehr dileep-ehr changed the title FLAT composition participation - wrong validation on name FLAT composition participation - wrong uniqueness lookup for id & name Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant