Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new event_manifest.yml file to generate edition files #58

Open
magnusbaeck opened this issue Jun 2, 2023 · 0 comments
Open

Use new event_manifest.yml file to generate edition files #58

magnusbaeck opened this issue Jun 2, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@magnusbaeck
Copy link
Member

magnusbaeck commented Jun 2, 2023

Description

Now that eiffel-community/eiffel#353 has been merged, the protocol repository contains a YAML file that describes the available editions and what event types and versions exist in that edition. We can use that to simplify
internal/cmd/editiongen/main.go.

Motivation

Less code to maintain.

Exemplification

N/A

Benefits

The end result should be identical to what we have now so in that sense it won't make a difference, but if we can do the same thing with less code that's a good thing.

Possible Drawbacks

We'll introduce a dependency to a new metadata file in the protocol git. On the other hand we get rid of a dependency to the protocol git's directory layout (and that it needs to be a Git repository).

@magnusbaeck magnusbaeck added the good first issue Good for newcomers label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant