Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile should verify downloaded golangci-lint executables #64

Closed
magnusbaeck opened this issue Jul 4, 2023 · 0 comments · Fixed by #65
Closed

Makefile should verify downloaded golangci-lint executables #64

magnusbaeck opened this issue Jul 4, 2023 · 0 comments · Fixed by #65
Assignees
@magnusbaeck

Comments

@magnusbaeck
Copy link
Member

Description

Right now the makefile blindly downloads and executes the golangci-lint installation script and accepts whatever it downloads as the linter to use. We should store the signatures of both files in the makefile and verify that they match.

Motivation

An attacker could compromise either file so that whoever builds the SDK runs arbitrary code.

Exemplification

N/A

Benefits

One security vulnerability down, N to go.

Possible Drawbacks

None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magnusbaeck magnusbaeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: Verify golangci-lint integrity before using it magnusbaeck/eiffelevents-sdk-go
1 participant
@magnusbaeck