better error messages on server upload #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinaas
force-pushed
the
better-error-messages
branch
from
b05201d
to
fea3daf
Compare
leftieFriele
requested review from
trygve-lie,
leftieFriele,
digitalsadhu and
wkillerud
There was a problem hiding this comment.
❤️ thanks for the PR 💪
For me putting the status code at the end makes it easier to read, especially since in all case except the default the status code more or less says the same as the error message.
It would give a log output like this:
Client attempted to send an invalid URL parameter, statusCode=400
Could not find server route, statusCode=404
Server failed 'file is undefined', statusCode=500
I've not done a lot of work in this module so I suggest waiting for others to chime in before changing anything in your PR 😄
wkillerud
approved these changes
May 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
## [2.0.38](v2.0.37...v2.0.38) (2024-05-13) ### Bug Fixes * include message from base error for unexpected status codes ([#549](#549)) ([d5637df](d5637df))
|
🎉 This PR is included in version 2.0.38 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes asset uploads fails with error messages:
Error: Error: Server failedError: Error: Server was unable to write file to storageWe need some more information about status code and message from the response to debug this.