Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese language #948

Closed
wallace11 opened this issue Jul 20, 2021 · 4 comments · Fixed by #961
Closed

Add Japanese language #948

wallace11 opened this issue Jul 20, 2021 · 4 comments · Fixed by #961
Labels
joex affects the joex component webui WebUI issues

Comments

@wallace11
Copy link
Contributor

Hi,
As discussed in #942 I'm requesting the addition of a new OCR language :)

Months
Number + 月 (ex: July is 7月)

Date formats
2021年7月21日
2021.7.21

I'd be grateful if you could reference the PR here so I could mimic it to add more languages :)

Thanks in advance!

@eikek
Copy link
Owner

eikek commented Jul 21, 2021

Oh Japanese, I hope I get that right :)! There is also #679 for an example issue adding another language.

@wallace11
Copy link
Contributor Author

Oh, you mean the short code?
Hm... Maybe we do Japanese numbers?

January 一月
February 二月
March 三月
April 四月
May 五月
June 六月
July 七月
August 八月
September 九月
October 十月
November 十一月
December 十二月

@eikek
Copy link
Owner

eikek commented Jul 22, 2021

I have really no clue about Japanese :/ - so to recognize dates in a text, thereare only the two, one via numbers (without leading zeros) and the other using names like '年', '月' and '日' or better use the numbers in Japanese?

@wallace11
Copy link
Contributor Author

As a full date, you have either one of the date formats that I mentioned in the beginning. Using only Japanese numbers is possible but uncommon.
If you refer only to months then it's possible to have both "normal" numbers and Japanese numbers.

Feel free to tag me in the PR and I'll go over it to make sure it looks fine :)

Thanks!

@eikek eikek added restserver Affects the rest server. webui WebUI issues joex affects the joex component and removed restserver Affects the rest server. labels Jul 28, 2021
@eikek eikek added this to the Docspell 0.25.0 milestone Jul 28, 2021
@mergify mergify bot closed this as completed in #961 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joex affects the joex component webui WebUI issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants