Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias page validity greater than the share validity #573

Open
frafra opened this issue Sep 15, 2021 · 5 comments
Open

Alias page validity greater than the share validity #573

frafra opened this issue Sep 15, 2021 · 5 comments

Comments

@frafra
Copy link

frafra commented Sep 15, 2021

Hi,
even if it is possible from the web interface to set different validities for the share and for the alias page, I wonder if that is intended and how the software would react to that. I found no reference to that in the documentation, nor the configuration files allows setting up different max-validity values.

It would be nice to be able to generate alias pages which have a long validity, but remove old files from time to time. Is that possible?

@eikek
Copy link
Owner

eikek commented Sep 15, 2021

Hi, I have to admit I can't even remember myself in all detail what I thought many years ago. Currently only published shares are cleaned up if the validity time has expired. I think it doesn't make sense to add a validity to an alias page - only if you decide to publish it.

@frafra
Copy link
Author

frafra commented Sep 16, 2021

The fact that only published content is cleaned up afterwards could be added to the documentation. Still, it would be nice to have an option to clean up all the shares I guess, no matter if they are public or not, after a certain period of time, as the system could keep data in a limbo forever and use more space for no useful reason.

The alias page has a "Validity" field which is independent of the share it is linked to. Should that be removed or linked somehow to the validity of the share?

Members and owners are not affected by these limitations at all. Such information could be added to the documentation, in my opinion. In my case, we have some external users which needs to be able to upload/send the data to us, which would be problematic due to the "Validity" settings, but I can just register them into Sharry once to fix that.

@frafra
Copy link
Author

frafra commented Sep 16, 2021

I see that each time there is a new bulk upload, a new share gets created. Then it makes sense that the validity of the alias page can differ from the one of the share.
Shares created by alias pages are not public by default, then they will never expire, which does not seem optimal, is that?

@eikek
Copy link
Owner

eikek commented Sep 17, 2021

The validity of an alias is "copied" to the share that is created by this alias. But as you wrote, these "private" shares are not taken into account in the cleanup. Maybe a flag could work that marks a share "not to cleanup" and everything eles is cleaned up. "Private" shares use the creation date as start date and others the end-date of the publish period.

@eikek
Copy link
Owner

eikek commented Sep 17, 2021

Sharry was once build for this use case mainly: upload a file, do some settings and publish it. You wouldn't upload a file without publishing it really. When receiving files, I download them and delete them immediately. I think the files uploaded through an alias should also be treated as "published" (like published to you, the owner). So maybe I should add the flag to the alias page, whether to clean files up or not. Files uploaded by an owner that are not published, can stay. I think this seems most sensible to me right now:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants