Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance on the Equivalent Address Resolver? #25

Open
ginkgomzd opened this issue Apr 21, 2022 · 3 comments
Open

Guidance on the Equivalent Address Resolver? #25

ginkgomzd opened this issue Apr 21, 2022 · 3 comments

Comments

@ginkgomzd
Copy link

The resolver docs mention:

Resolves (some) cases where the addresses are the same but one has more detail (eg. one is just the country & the other is a full address in that country)

I have a case where multiple imports were done without street addresses, but most other address fields.
Do I need to do something to make use of the EAR? Or is it working, but not for this case?

I'm still working my way through the docs... are there code-extension points I can use if the default EAR won't resolve this case?

Thanks!

@eileenmcnaughton
Copy link
Owner

@ginkgomzd I think it's a bit more limited than that - it's one of those things that obviously hits the use cases that we have had to deal with - issues around Country & postal_code

I haven't put much thought into making it extensible - but it would probably be easish to patch with a check for empty(street_address) - would it work to do a stristr to compare the 2 addresses - ie I think it comes out as an address string so if either one is a partial of the other we could pick the longer one?

@ginkgomzd
Copy link
Author

I think just considering a sub-string-match would be too broad.

I need to think more on the problem. I'm not sure I can't just configure a traditional dedupe rule with threshholds to give me the confidence to do a force-merge.

Last time I enabled the extension, it caused errors. My first thought is that it has to do with the PHP(8) version. So I intend to get into the code in a development environment. Any pointers on where to look in the code for resolvers could be useful.

Thanks!

@eileenmcnaughton
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants