Paypal Checkout Page Issues

[mwestergaard]

Contribution pages with Paypal Checkout have stopped working for me. I noticed that the Total Amount isn't updating and the Payment Options doesn't show. I also use the Extra Fee extension and it doesn't appear. I get a bunch of javascript errors in the console.

If I hit the Contribute button, the page refreshes, fills in the Total Amount, offers the Extra Fee option, and then lets me select a payment method (no js errors).

If I then select PayPal Checkout and hit the Paypal button, I get an error: "Site is not correctly configured to process payments".

I am at CiviCRM 5.28.0, Omnipay 3.11, and Extra Fee 1.2. I tried disabling Extra Fee on the payment processor to see if it was contributing to the problem, but it didn't make a difference.

[eileenmcnaughton]

@mwestergaard was it working for you previously on different versions?

[eileenmcnaughton]

@mwestergaard I just tested & hit the same issue - reverting 999a7e5 got me past it - are you able to test master?

[eileenmcnaughton]

@mwestergaard I've published 3.12 with that reverted - per comments here - #164 I have a hunch it could be caching but will re-add that more cautiously if it turns out to be the case

[mattwire]

@eileenmcnaughton @mwestergaard Please see/test #166 which should resolve both issues.

[mwestergaard]

Thanks. I installed 3.12 but still same behavior. I verified I have the new omnipay_PaypalRest.js, flushed CiviCRM cache, cleared browser cache, etc. I'll keep trying!

[eileenmcnaughton]

@mwestergaard did this work for you previously? Does anything start to load. I got an error before doing the mentioned revert but then I got an error a bit later in the process afterwards (because I had test credentials & tried it in live mode). Also maybe try the patch above

[mwestergaard]

@eileenmcnaughton Yes, my contribution pages and payment processor haven't been altered since we started using the Omnipay extension about a year ago, but I believe I found a clue. I had a vague memory of a similar issue occurring in the past. I had to scratch my brain, but I remembered reporting it (#126 (comment)). I found that if I switch my default Payment Processor to something other than PayPal Checkout, everything seems to work with PayPal Checkout and #166. I see no js errors.

The only thing is see different is the Contribute button is hanging around until the Paypal Checkout buttons appear. I'm pretty sure it wasn't displaying at all unless I selected Pay Later (my only other payment option). Perhaps I'm hallucinating!

[eileenmcnaughton]

@mwestergaard can you try reverting this - b9d5719 - I tested with paypal checkout as non-default so that could explain why it worked for me

[mwestergaard]

@eileenmcnaughton That was successful! Tested on two systems with results as expected. I reset PayPal Checkout as the default payment processor (and cleared Civi's cache). Everything behaved and completed a couple of test payments.

Ignore my comment about the Contribute button. There was no default payment option on the form at that point, so it makes sense.

[eileenmcnaughton]

@mwestergaard OK - I've reverted that too - I'll release 3.13 without those 2 fixes & then when I have time sit down & try to work through @mattwire's proposed alternate

[mwestergaard]

@eileenmcnaughton Thanks much!

[eileenmcnaughton]

@mwestergaard thanks for reporting it quickly- I still need to revisit re-fixing but at least the regression won't hit others