Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag configurable #111

Closed
smeijer opened this issue Mar 3, 2020 · 3 comments
Closed

Make tag configurable #111

smeijer opened this issue Mar 3, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smeijer
Copy link

smeijer commented Mar 3, 2020

It would be nice if we could provide the tag name to use. Currently, it's called tip. I would favor a tag latest or nightly instead.

If the tag is configurable, I can even imagine using various cronjobs with different tags.

@eine
Copy link
Owner

eine commented Mar 6, 2020

Hi @smeijer! Note that this repo is more of a proof of concept, rather that an actually used project. This is because I found no mechanism to avoid watchers being explicitly notified about each release. In the context of this projects, that's really annoying... I'd like to explore if https://github.com/eine/tip/blob/master/ts/main.ts#L35 can help with avoiding it. Unfortunately, I have other priorities, and I cannot devote time to this repo ATM.

Anyway, I agree that making the tag name configurable is a useful feature. Moreover, some examples can be provided about how to use the branch name for it.

@eine eine added enhancement New feature or request good first issue Good for newcomers labels Mar 6, 2020
@smeijer
Copy link
Author

smeijer commented Mar 12, 2020

Yeah, I understand. The release spamming is an issue indeed. For me it was enough of a reason to no longer include tip in our workflow.

Still grateful for your work though :) The idea behind tip can be of great value.

@eine
Copy link
Owner

eine commented May 14, 2020

Spamming issues should be fixed in the new Python version of the Action. Now, the same release is reused and the tag is force-pushed, instead of removing and creating the release each time.

At the same time, the tag is now configurable through an option or environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants