Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(tui): Key bindings work while typing in filter mode #148

Open
ruslanSorokin opened this issue Jun 16, 2023 · 1 comment
Open

Bug(tui): Key bindings work while typing in filter mode #148

ruslanSorokin opened this issue Jun 16, 2023 · 1 comment
Labels

Comments

@ruslanSorokin
Copy link

ruslanSorokin commented Jun 16, 2023

Environment

code --version:

1.79.1
4cb974a7aed77a74c7813bdccd99ee0d04901215
x64

go version:

go version go1.20.5 linux/amd64

gh --version:

gh version 2.30.0 (2023-05-30)
https://github.com/cli/cli/releases/tag/v2.30.0

gh-dependabot version: v0.10.12

Problem

I use the extension inside vscode terminal emulator, so it may be vscode problem - something related to direct input or something like that. However, this is critical issue since I've already merged 2 PR unintentionally, while typing in filter mode.

Expected behavior

When entering filter mode, all key bindings should be disabled because otherwise you can do some phantom things while you are simply typing something.

Actual behavior

When entering filter mode all key bindings are still enabled.

Copy link

This issue has been open for 365 days with no activity. Marking as stale.

@github-actions github-actions bot added the Stale label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant