feat(golangcilint): disable forcetypeassert linter
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edholm
requested review from
alethenorio,
odsod,
thall and
viktorvoltaire
as code owners
Edholm
changed the title
forcetypeassert linter
odsod
approved these changes
Jan 10, 2022
this linter has a bit too many false positives where the assetion has been checked beforehand. Let's remove it for now and re-add it for a stricter linter in the future.
Edholm
force-pushed
the
chore/remove-forcetypeassert
branch
from
4697143
to
6bdd4c3
Compare
Edholm
changed the title
forcetypeassert linterforcetypeassert linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this linter has a bit too many false positives where the assetion has
been checked beforehand. Let's remove it for now and re-add it for a
stricter linter in the future.