Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's THETA function? #10

Closed
pfalcon opened this issue May 18, 2015 · 5 comments
Closed

What's THETA function? #10

pfalcon opened this issue May 18, 2015 · 5 comments

Comments

@pfalcon
Copy link

pfalcon commented May 18, 2015

As used in:

i@4 = THETA(i@0, i@4, ) + 1;

It's used in context where PHI function is usually used (join several SSA variables into one): http://en.wikipedia.org/wiki/Static_single_assignment_form . vanEmmerik_ssa.pdf you give as a reference also used standard terminology of phi.

@EiNSTeiN-
Copy link
Owner

Same thing, I guess I need to review my ssa terminology

@pfalcon
Copy link
Author

pfalcon commented May 18, 2015

Well, if you target this project not as a personal hack, but for general community consumption (*), I suggest to not be afraid of global search&replace commit to make it more clear/accessible.

  • And someone really should, and your project, being no.2 in my today's review list, looks pretty good for that (at least it does SSA and refers to a complete thesis of a known guy in the field). And fairly speaking, I don't have many more entries in my list :-(.

@EiNSTeiN-
Copy link
Owner

Well, if you target this project not as a personal hack, but for general community consumption

That would be the goal but we're not there yet :)

search&replace commit to make it more clear/accessible.

I will, thanks for the suggestion. You are not the first one to mention that I'm using theta instead of phi.

@EiNSTeiN-
Copy link
Owner

Fixed in 338cb8c

@pfalcon
Copy link
Author

pfalcon commented May 23, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants