Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Notebooks due to addition of predefined metrics #430

Closed
2 tasks
ritzvik opened this issue Feb 13, 2020 · 1 comment 路 Fixed by #435
Closed
2 tasks

Update Notebooks due to addition of predefined metrics #430

ritzvik opened this issue Feb 13, 2020 · 1 comment 路 Fixed by #435
Labels
documentation good first issue Good for newcomers symbolic

Comments

@ritzvik
Copy link
Member

ritzvik commented Feb 13, 2020

馃悶 Problem
Now, there are predefined metrics available in symbolic module. Use them in example notebooks

馃幆 Goal

  • Notebook I - Replace the deprecated SchwarzschildMetric, with that from predefined module.
  • Notebook II - Use AntiDeSitter from predefined module, instead of explicitly defining it.

馃挕 Possible solutions

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@nimeshvashistha
Copy link
Contributor

nimeshvashistha commented Feb 21, 2020 •
edited

@ritzvik I'd like to work on this issue

This was referenced Feb 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue Good for newcomers symbolic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notebook nimeshvashistha/einsteinpy
2 participants
@ritzvik @nimeshvashistha