Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra characters on repeated Emojis #2104

Closed
sanzoghenzo opened this issue Feb 20, 2024 · 1 comment 路 Fixed by #2105
Closed

Extra characters on repeated Emojis #2104

sanzoghenzo opened this issue Feb 20, 2024 · 1 comment 路 Fixed by #2105

Comments

@sanzoghenzo
Copy link
Contributor

sanzoghenzo commented Feb 20, 2024

馃悶 Describe the bug

Problem raised in this forum discussion.

image

Note that this is not strictly related to tables, but with repeated emojis and how the Emojize c# method performs the substitutions.

The regex Match finds all the shorthands, then for each of them it retrieves the icon and performs a replace on the entire text with an html tag with the shorthand as title.
The subsequent match of the same shorthand repeats the replace on the shorthand contained in the title, causing a recursion. that produces extra ">s in the output.

The solution here is to take only the unique/distinct matches of the regex.

As I discussed in the linked topic, it may also be the case to drop the zip archive containing the icons and rely on fonts such as Noto Color Emoji and unicode chars.

I'm already working to address both issues.

@jmcouffin
Copy link
Contributor

Fixed by #2105
Thanks @sanzoghenzo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants