Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matches-selector update breaks this #15

Closed
thgil opened this issue Dec 31, 2015 · 4 comments
Closed

Matches-selector update breaks this #15

thgil opened this issue Dec 31, 2015 · 4 comments

Comments

@thgil
Copy link

thgil commented Dec 31, 2015

You get this error when you load this component now.
Uncaught TypeError: elem[matchesMethod] is not a function

I think its because https://github.com/desandro/matches-selector got updated to v2.0.0
@kenotron
Copy link

I'm hitting this as well. The idea of taking a github.com/desandro/matches-selector as dependency instead of pegging to a MAJOR version is risky at best. Also, not sure why use so much of your own forks of @desandro 's software?

@eiriklv
Copy link
Owner

eiriklv commented Dec 31, 2015

@thgil @kenotron See #14

@afram
Copy link
Collaborator

afram commented Dec 31, 2015

@thgil @kenotron this should be fixed now - can you please try installing again?

@thgil
Copy link
Author

thgil commented Dec 31, 2015

@afram Thanks a lot, it's working again.

@thgil thgil closed this as completed Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kenotron @thgil @afram @eiriklv