Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Idea - Infinite scrolling #25

Closed
dcworldwide opened this issue Jan 21, 2016 · 8 comments
Closed

Fork Idea - Infinite scrolling #25

dcworldwide opened this issue Jan 21, 2016 · 8 comments

Comments

@dcworldwide
Copy link

HI @eiriklv, thanks for the great project. 馃憤 I have a general question. I need to extend your work to add infinite scrolling. My plan is to fork your work and make my sub-project available to others. I'm pretty new to React and Masonry, so i was wondering if you had any thoughts on how you would solve this problem? Furthermore, are there any infinite scrolling libs that you know of which would be a good fit for integrating with your work? thanks

@eiriklv
Copy link
Owner

eiriklv commented Jan 21, 2016

Hi @dcworldwide, and thanks!

There's already an example of react-masonry-mixin and infinite scroll here:

It's using a fork of react-infinite-scroll :-)

@eiriklv
Copy link
Owner

eiriklv commented Jan 21, 2016

Though I see now that this is using the old react-masonry-mixin, which was my first approach, but you should be able to do something similar.

@eiriklv
Copy link
Owner

eiriklv commented Jan 21, 2016

Something like in the fashion of:

<Masonry {...}>
  <InfiniteScroll {...}>
    {elements}
  </InfiniteScroll>
</Masonry>

@dcworldwide
Copy link
Author

@eiriklv Very neat! I'm going to spend some time tomorrow getting this working. Thanks again!

@eiriklv
Copy link
Owner

eiriklv commented Jan 22, 2016

@dcworldwide No worries! Have fun :-)

@bfic
Copy link

bfic commented Jan 31, 2016

@dcworldwide could you be so kind and share your approach ? I am trying to do same thing (using react-mysonry-component with react-infinite-scroll)

@dcworldwide
Copy link
Author

Hey @bfic

@eiriklv's approach above works well. I had no issue getting it working, but in the end, I decided not to use react-inifinite-scroll but instead used https://github.com/joshwnj/react-visibility-sensor. My choice was largely because I didn't feel comfortable using a fork, but that is just a preference. Either works well.

@matthewlilley
Copy link

Thanks @dcworldwide, exactly what I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants