-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version designation not standard. #1075
Comments
I just want to come back and say thought that this plugin is amazing. Thank you so much for creating it!! Please consider this ticket as an attempt to make something really good even better. The most important thing is that the plugin works, and it works like a charm. |
Yeah, I agree it's a bit weird. It's for historical reasons. This plugin was initially released back in the day when Node The way this plugin works, is that it builds the download URL dynamically based on |
This is a small issue, but if I indicate the Node version like this:
I get a warning:
It is true that if there is no context, prefixing something with a
v
is the convention for indicating that it is a version. For example tagging a Git repository commit withv1.2.3
is preferable to1.2.3
, because you don't necessarily know what1.2.3
means.But here the name of the element is
<nodeVersion>
, and the name of the setting isnodeVersion
. There is no ambiguity about what1.2.3
means, and indicatingv1.2.3
as the value is redundant, as the setting name already indicates "version". Furthermore this is not the standard practice for maven dependency version indication; normally one does not indicatev…
in the value.Again this is a little thing, but it's a thing nevertheless. 😄
The text was updated successfully, but these errors were encountered: