Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please included tests in pypi release #13

Closed
jlec opened this issue Nov 9, 2015 · 5 comments · Fixed by #22
Closed

Please included tests in pypi release #13

jlec opened this issue Nov 9, 2015 · 5 comments · Fixed by #22
Assignees

Comments

@jlec
Copy link

jlec commented Nov 9, 2015

Downstream developer love to test during their installation process. Please include the tests in the pypi tarball.

@eisensheng
Copy link
Owner

I understand your pain. Testing the integrity of an entire distribution of multiple packages is hard.

My general stance towards PYPI used to be that packages go there to be installed, through PIP for example. Not to be redistributed and tested somewhere else. This is where the release archives provided by Github comes into play.

Since PYPI also offers a "Source Distribution" of the given package for download and thus having two different flavors of a Source Distribution that comes from Github and the Source Distribution that comes from the PYPI is bad. This is terrible to be honest. Thanks for pointing this out. I didn't realize that before.

My propose for this issue thus would be to keep both Source Distributions the same but do not install the test suite through PIP or other means. Does this sound acceptable for you? If an agreement can't be reached I would also be in to drop my stance and just install the test suite together with the plugin itself.

@jlec
Copy link
Author

jlec commented Nov 9, 2015

Probably you got me wrong. I would like to have the tests contained in the pypi tarball, but not installed using pip. We are fetching the tarball, running python setup.py build, running the tests according to how upstreams test (e.g. through travis) and running python setup.py install. So we only need the tests contained in the tarball not installed to the system

@abusalimov
Copy link
Collaborator

@jlec Could you help us and specify what exactly we should add into setup.py? Honestly, (personally) I'm a kind of setuptools newbie. Any link to a package with a "good" setup.py as an example would be fine too. Thanks.

@eisensheng
Copy link
Owner

@abusalimov We should patch MANIFEST.in to include the test files. I was already playing around with this yesterday.

@abusalimov
Copy link
Collaborator

Ah, awesome!
I'll assign this to you then, OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants