Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check resource changes dict logic everywhere #96

Closed
nicholasmhughes opened this issue Jun 7, 2020 · 2 comments
Closed

check resource changes dict logic everywhere #96

nicholasmhughes opened this issue Jun 7, 2020 · 2 comments

Comments

@nicholasmhughes
Copy link
Member

only return changes that are being made (instead of the whole object)
@nicholasmhughes nicholasmhughes created this issue from a note in Release 2.3 (To do) Jun 7, 2020
@nicholasmhughes nicholasmhughes added this to To do in Release 2.4 via automation Jun 7, 2020
@nicholasmhughes nicholasmhughes removed this from To do in Release 2.3 Jun 7, 2020
@nicholasmhughes
Copy link
Member Author

Also... make sure the changes dict is formatted properly... look at the keyvault/secrets state module for the proper format.

@nicholasmhughes nicholasmhughes removed this from To do in Release 2.4 Jul 4, 2020
@nicholasmhughes nicholasmhughes added this to To do in Release 3.0 via automation Jul 4, 2020
@nicholasmhughes nicholasmhughes removed this from To do in Release 3.0 Aug 10, 2020
@Ajnbro
Copy link
Contributor

Ajnbro commented Sep 10, 2020

With the addition of the action variable within states, this will be addressed by the broader issue posed within #188.

@Ajnbro Ajnbro closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicholasmhughes @Ajnbro