Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use csv.QUOTE_NONNUMERIC instead of csv.QUOTE_NONE #21

Closed
ejach opened this issue Jan 14, 2022 · 1 comment
Closed

Use csv.QUOTE_NONNUMERIC instead of csv.QUOTE_NONE #21

ejach opened this issue Jan 14, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ejach
Copy link
Owner

ejach commented Jan 14, 2022

Use csv.QUOTE_NONNUMERIC instead of csv.QUOTE_NONE in

csv_writer = writer(data_file, quoting=QUOTE_NONE, quotechar=None, delimiter='\n')

to quote all non-numeric strings by default instead of this line

 title = '"%s"' % ' '.join([a.strip() for a in name.split('\n') if a]) if ',' in name else name

For code clarity and efficiency 💯

@ejach ejach self-assigned this Jan 14, 2022
@ejach ejach added the enhancement New feature or request label Jan 14, 2022
@ejach
Copy link
Owner Author

ejach commented Jan 14, 2022

Well, what I thought this module did was not what it actually does.

@ejach ejach closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant