Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query WCS directly to get the rotation and scale #834

Open
ejeschke opened this issue Apr 14, 2020 · 1 comment
Open

Query WCS directly to get the rotation and scale #834

ejeschke opened this issue Apr 14, 2020 · 1 comment
Labels
maintenance Work done to keep code maintained

Comments

@ejeschke
Copy link
Owner

looking at your implementation of ginga.util.mosaic.CanvasMosaicer, it seems like it uses FITS WCS. For this purpose, I think that is fine (or can be left as a future PR if GWCS is really necessary).

Unfortunately, it is simply looking at the FITS header. I think it would be better to query the WCS directly to get the rotation and scale. That should support GWCS. I think a new PR would be appropriate, basically moving the functions from ginga.util.wcs to the wrappers in ginga.util.wcsmod. There it could eventually be refactored to make the appropriate calls to the actual wcs objects.

Originally posted by @ejeschke in #812 (comment)

@ejeschke
Copy link
Owner Author

If there are routines in astropy WCS to get rotation and scale from an image's FITS keywords, use that implementation rather than Ginga's.

@ejeschke ejeschke added the maintenance Work done to keep code maintained label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Work done to keep code maintained
Projects
None yet
Development

No branches or pull requests

1 participant