You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
looking at your implementation of ginga.util.mosaic.CanvasMosaicer, it seems like it uses FITS WCS. For this purpose, I think that is fine (or can be left as a future PR if GWCS is really necessary).
Unfortunately, it is simply looking at the FITS header. I think it would be better to query the WCS directly to get the rotation and scale. That should support GWCS. I think a new PR would be appropriate, basically moving the functions from ginga.util.wcs to the wrappers in ginga.util.wcsmod. There it could eventually be refactored to make the appropriate calls to the actual wcs objects.
Unfortunately, it is simply looking at the FITS header. I think it would be better to query the WCS directly to get the rotation and scale. That should support GWCS. I think a new PR would be appropriate, basically moving the functions from
ginga.util.wcs
to the wrappers inginga.util.wcsmod
. There it could eventually be refactored to make the appropriate calls to the actual wcs objects.Originally posted by @ejeschke in #812 (comment)
The text was updated successfully, but these errors were encountered: