Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain method in array #115

Closed
alu opened this issue Jul 17, 2013 · 2 comments
Closed

Chain method in array #115

alu opened this issue Jul 17, 2013 · 2 comments
Labels

Comments

@alu
Copy link

alu commented Jul 17, 2013

Thank you for great expansion.

Example

['hoge' => $this->please()
->help()
->me()];

Ideal

['hoge' => $this->please()
                ->help()
                ->me()];
@ejmr
Copy link
Collaborator

ejmr commented Jul 18, 2013

Thank you for opening the issue, because I agree that would be more ideal, and more consistent with previous changes. We need to keep in mind not to re-break previous issues like #81 but I believe we can add support for this alignment without too much trouble.

@ejmr
Copy link
Collaborator

ejmr commented Aug 28, 2013

Fixed by 6c394e9, although I have some reservations about the patch which I describe in the commit message. I decided to merge it because it corrects the problem in this issue. But the approach may cause unforseen problems since the test suite does not sufficiently cover the related indentation scenarios.

@ejmr ejmr closed this as completed Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants