Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrasts seem to be broken on rpy2 >= 3.2 #60

Closed
ejolly opened this issue May 6, 2020 · 3 comments
Closed

Contrasts seem to be broken on rpy2 >= 3.2 #60

ejolly opened this issue May 6, 2020 · 3 comments
Labels
bug

Comments

@ejolly
Copy link
Owner

ejolly commented May 6, 2020

Lmer.fit(factors={...} does not properly set contrasts anymore and it seems to be because the contrasts function call doesn't preserve the contrast code when converting back to pandas. Opened an issue in on the rpy2 github here rpy2/rpy2#699 to see if there's any advice
@ejolly ejolly added the bug label May 6, 2020
This was referenced May 6, 2020
Closed
Open
@ejolly
Copy link
Owner Author

ejolly commented May 6, 2020 •
edited
Loading

Partially fixed in #61.

See #TODOs in code for additional changes required.

@ejolly
Copy link
Owner Author

ejolly commented Jun 24, 2020

Bug fixes

@ejolly
Copy link
Owner Author

ejolly commented Jul 7, 2020

Fixed in a254059

@ejolly ejolly closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ejolly