Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Rails 5 #84

Closed
janraasch opened this issue Jan 5, 2016 · 10 comments
Closed

Integration with Rails 5 #84

janraasch opened this issue Jan 5, 2016 · 10 comments

Comments

@janraasch
Copy link

Hi there, Happy New Year!

Currently, when trying to install this together with rails v5.0.0.beta1, bundler will install

  * sinatra-1.0.gem
  * delayed_job_web-1.2.5.gem

since 1.0 is the only version of sinatra which does not restrict itself to rack v1.x, "< 2", and rails v5.0.0.beta1 runs on rack 2.0.0.alpha.

Are you planning to support Rails 5? If so, how could we move forward to achieve that goal?

@chrismear
Copy link
Contributor

Probably the best approach is to help get a new release of Sinatra 1 released that is compatible with Rack 2: sinatra/sinatra#1061

@janraasch
Copy link
Author

@chrismear, sounds good. I suppose this is issue is onhold until sinatra/sinatra#1061 is decided then.

@devilankur18
Copy link

+1

@devilankur18
Copy link

This fixed the issue

gem "sinatra", github: 'sinatra/sinatra'
gem "rack-protection", github: 'sinatra/rack-protection'
gem "delayed_job_web"

@wfried
Copy link

wfried commented Aug 23, 2016

There is now a release of sinatra (v2.0.0.beta2) which supports Rails 5.

@tom-lord
Copy link

I also just encountered this issue when upgrading an application to Rails 5.

Loading the application fails with the following error:

gems/activesupport-5.0.1/lib/active_support/dependencies.rb:293:in `require':
  cannot load such file -- rack/showexceptions (LoadError)

The current solution is to simply add the line:

gem 'sinatra', '>= 2.0.0.beta2'

to your Gemfile.

For more detail, see this issue in Sinatra.

@mmhan
Copy link

mmhan commented Aug 24, 2017

Wondering what's the updated solution for this. Is there a new version lined up for this gem?

@janraasch
Copy link
Author

Since all sinatra issues are solved (see links to issues above), the problem is fixed. We already use this gem with rails v5 in production.

@ACPK
Copy link

ACPK commented Aug 14, 2019

@ejschmitt - Should the readme be updated to say it supports Rails5?

@andyatkinson
Copy link
Collaborator

@ACPK Sure. Could you please do that as a new PR and I will merge it in? According to @janraasch they're using it with Rails 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants