Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS remote - "up next" is empty when player stopped #823

Open
whatdoineed2do opened this issue Sep 30, 2019 · 0 comments
Open

IOS remote - "up next" is empty when player stopped #823

whatdoineed2do opened this issue Sep 30, 2019 · 0 comments

Comments

@whatdoineed2do
Copy link
Contributor

If the player is stopped and we connect to the server with IOS 13 remote app, the "up next" is empty even if we have items in the play queue.

The IOS remote app only becomes aware of the queued items when we start play or are in paused state.

A simple fix can be:

--- a/src/httpd_dacp.c
+++ b/src/httpd_dacp.c
@@ -1751,6 +1751,18 @@ dacp_reply_playqueuecontents(struct httpd_request *hreq)
 
       while ((db_queue_enum_fetch(&qp, &queue_item) == 0) && (queue_item.id > 0) && (count < span))
        {
+         // if we're not playing, the "up next" is empty even if the queue table is not empty
+         if (status.status == PLAY_STOPPED)
+           {
+             if (playqueuecontents_add_queue_item(songlist, &queue_item, count, status.plid) < 0)
+               {
+                 db_queue_enum_end(&qp);
+                 goto error;
+               }
+             ++count;
+             continue;
+           }
+
          if (status.item_id == 0 || status.item_id == queue_item.id)
            {
              count = 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant