Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile.vim should recognize Dockerfile.multi #51

Closed
webermaster opened this issue Jan 3, 2018 · 3 comments
Closed

dockerfile.vim should recognize Dockerfile.multi #51

webermaster opened this issue Jan 3, 2018 · 3 comments

Comments

@webermaster
Copy link

webermaster commented Jan 3, 2018

Currently Dockerfile.vim seems to only recognize files by the name of "Dockerfile". From what I've seena common naming convention for multistage builds is "Dockerfile.multi". Should Dockerfile.vim recognize this filename for syntax highlighting as well?

screen shot 2018-01-03 at 8 09 21 am

@belak
Copy link

belak commented Apr 15, 2018

I'm not sure this is true - https://github.com/ekalinin/Dockerfile.vim/blob/master/ftdetect/Dockerfile.vim#L3

That seems to match any file that starts with Dockerfile.

Are you still having this issue? When I tried to reproduce this it seemed to work without any problems.

@bgaillard
Copy link

Hi, in my case I can open a file named Dockerfile.android and coloration works as expected. So IMO this issue can be closed. @webermaster do you agree ?

@ekalinin
Copy link
Owner

ekalinin commented Mar 4, 2019

@webermaster please, try the latest version of the Dockerfile.vim

Just tried:

➜ vim Dockerfile.multi

and file type was set correctly.

@ekalinin ekalinin closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants